Bump minimum Python version to 3.8 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
victorlin/update-python-versions
branch
5 times, most recently
from
59430a2 to
efdb042
Compare
victorlin
changed the title
victorlin
force-pushed
the
victorlin/update-python-versions
branch
2 times, most recently
from
6e6cd68 to
87ca344
Compare
|
Would you add an entry to the changelog for this PR? |
tsibley
approved these changes
Nov 17, 2023
Subsequent commits will remove the 3.6 and 3.7-specific workarounds.
This comes with the standard library as of Python 3.7¹. ¹ https://docs.python.org/3.7/whatsnew/3.7.html
It comes with the standard library as of Python 3.8¹. ¹ https://docs.python.org/3.8/whatsnew/3.8.html#new-modules
The motivation to use argparse was presumably to replace the hardcoded prefix matching with argparse's built-in functionality¹. That seems tricky since the current prefix matching omits some patterns (e.g. --co for --cores, -re for --resources) which would be included by argparse unless some workarounds are applied. The current implementation seems reasonable, so leave it as-is. ¹ https://docs.python.org/3.8/library/argparse.html#prefix-matching
This wrapper around subprocess.run() was initially created because its own capture_output parameter wasn't added until Python 3.7. However, other things happening in this wrapper - namely environment variable handling and return value modification - have turned out to be generally useful. Seems worthwhile to keep it as-is.
The test environment can now be set up properly.
victorlin
force-pushed
the
victorlin/update-python-versions
branch
from
58104af to
ea0b766
Compare
|
Changelog entry added in e15afcc. |
tsibley
added a commit
that referenced
this pull request
May 9, 2024
Missed as part of the bump from Python 3.6 → 3.8.¹ ¹ <#325> Co-authored-by: Thomas Sibley <[email protected]>
tsibley
added a commit
that referenced
this pull request
May 9, 2024
Missed as part of the bump from Python 3.6 → 3.8.¹ ¹ <#325> Co-authored-by: Thomas Sibley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Drop support for Python 3.6 and 3.7. Adding support for newer versions will be done in separate PRs.
Related issue(s)
Checklist