-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed path to RDP and SILVA ref files #837
Conversation
Release 2.9.0
Release 2.10.0
Release 2.11.0
Release 2.12.0
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts, assuming all tests succeed.
You updated because the record
links do redirect anyway to records
, right?
Edit: Ah I see the linked issue now. All clear ;)
Resolved merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for the effort, but there seems to be some issue with the PR because Silva 138.2 database entry was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d4straub Ah, thanks! Sorry for not checking this before, I'm quite new to nf-core. I think this should work now? Edit: I don't understand why the tests are not producing the desired output files, could use some help here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Edit: I don't understand why the tests are not producing the desired output files, could use some help here.
All CI tests are run with nextflow version 24.04.2 and the latest nf version. All tests with nf version 24.04.2 succeed, that is the required part. The latest nf version is however incompatible with the current nf-core template, when updating to th newest template that should be fixed.
Edit: do you want to do the honors and merge the PR?
Thanks for the explanation!
Ha, I don't think I have the necessary permissions 😄 I see no Merge option |
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).Fixing path from zenodo.org/record to zenodo.org/records to fix db staging error. Closes #834