Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests in dog genome #119

Merged
merged 6 commits into from
Aug 31, 2024
Merged

Improve tests in dog genome #119

merged 6 commits into from
Aug 31, 2024

Conversation

atrigila
Copy link
Collaborator

@atrigila atrigila commented Aug 18, 2024 •
edited
Loading

Test panelprep and imputation in dogs.
Closes #120

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@atrigila atrigila self-assigned this Aug 18, 2024
@atrigila atrigila marked this pull request as ready for review August 25, 2024 21:39
@atrigila atrigila requested a review from LouisLeNezet August 25, 2024 21:39
LouisLeNezet
LouisLeNezet approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go for me !

@atrigila @LouisLeNezet
Update conf/test_dog.config
7702b0f 
Co-authored-by: Louis LE NEZET <[email protected]>
@atrigila atrigila merged commit e7d34a4 into nf-core:dev Aug 31, 2024
10 checks passed
@LouisLeNezet LouisLeNezet added the enhancement New feature or request label Oct 29, 2024
@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisLeNezet LouisLeNezet LouisLeNezet approved these changes

Assignees

@atrigila atrigila

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.99.0
Development

Successfully merging this pull request may close these issues.

Add tests with dog data
2 participants
@atrigila @LouisLeNezet