Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BAM_REGION optional #84

Merged
merged 5 commits into from
Jun 8, 2024
Merged

Conversation

LouisLeNezet
Copy link
Collaborator

USe samtools depth instead of coverage

Now simulation by chromosome is optional.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet marked this pull request as ready for review June 7, 2024 15:29
@LouisLeNezet LouisLeNezet self-assigned this Jun 7, 2024
@LouisLeNezet LouisLeNezet added bug Something isn't working enhancement New feature or request labels Jun 7, 2024
@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Jun 7, 2024
@LouisLeNezet LouisLeNezet linked an issue Jun 7, 2024 that may be closed by this pull request
@LouisLeNezet LouisLeNezet changed the title Add parameter sim_by_chr Make BAM_REGION optional Jun 7, 2024
@LouisLeNezet LouisLeNezet requested a review from atrigila June 7, 2024 15:43
@LouisLeNezet LouisLeNezet requested a review from atrigila June 8, 2024 17:21
Copy link
Collaborator

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LouisLeNezet LouisLeNezet merged commit f7e5586 into nf-core:dev Jun 8, 2024
8 checks passed
@LouisLeNezet LouisLeNezet deleted the simulate branch October 1, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make split the bam into the region specified optional
2 participants