Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CRAM, check contigs name #93

Merged
merged 60 commits into from
Jul 10, 2024
Merged

Conversation

LouisLeNezet
Copy link
Collaborator

@LouisLeNezet LouisLeNezet commented Jun 23, 2024

Here we add support for CRAM file as input.
The contigs names are now check at workflow level for all input (bam and vcf).
Fix glimpse2 file naming.
Remove samples in one step with removing multiallelics records.
Publish only once the reference panel.
Moove samtools merge to BAM_REGION sbwf and fix renaming.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet self-assigned this Jun 23, 2024
@LouisLeNezet LouisLeNezet added bug Something isn't working enhancement New feature or request labels Jun 23, 2024
@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Jun 23, 2024
This was linked to issues Jun 23, 2024
@LouisLeNezet LouisLeNezet requested a review from atrigila July 1, 2024 07:39
@LouisLeNezet LouisLeNezet requested a review from atrigila July 5, 2024 14:01
Copy link
Collaborator

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ask for an additional review to revise the new workflow.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can you submit this updated module to nf-core modules as well? Then we can do the migration from local to nf-core modules.

@LouisLeNezet LouisLeNezet requested a review from atrigila July 8, 2024 13:06
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it

Copy link
Collaborator Author

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go

@LouisLeNezet LouisLeNezet merged commit a342791 into nf-core:dev Jul 10, 2024
8 checks passed
@LouisLeNezet LouisLeNezet deleted the cram branch October 1, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fasta fai and doc Future improvement
3 participants