Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sv benchmark params are exposed #34

Merged
merged 6 commits into from
May 7, 2024
Merged

sv benchmark params are exposed #34

merged 6 commits into from
May 7, 2024

Conversation

kubranarci
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantbenchmarking branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@kubranarci kubranarci linked an issue Apr 26, 2024 that may be closed by this pull request
exposing benchmarking params #33
Closed
@kubranarci kubranarci requested a review from maxulysse April 26, 2024 16:11
maxulysse
maxulysse reviewed Apr 26, 2024
View reviewed changes
nvnieuwk
nvnieuwk reviewed May 2, 2024
View reviewed changes
@kubranarci kubranarci self-assigned this May 6, 2024
nvnieuwk
nvnieuwk reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment! I'll approve once that's been fixed :)

nvnieuwk
nvnieuwk approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos left but otherwise it LGTM

@kubranarci @nvnieuwk
Update README.md
156eaf7 
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
@kubranarci kubranarci merged commit c1c1735 into dev May 7, 2024
4 checks passed
@kubranarci kubranarci deleted the 33-exposing-benchmarking-params branch May 7, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse

Assignees

@kubranarci kubranarci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exposing benchmarking params
3 participants
@kubranarci @maxulysse @nvnieuwk