Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 somatic benchmarking #43

Merged
merged 10 commits into from
May 29, 2024
Merged

41 somatic benchmarking #43

merged 10 commits into from
May 29, 2024

Conversation

kubranarci
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantbenchmarking branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@kubranarci kubranarci self-assigned this May 28, 2024
@kubranarci kubranarci linked an issue May 28, 2024 that may be closed by this pull request
@kubranarci kubranarci requested a review from nvnieuwk May 29, 2024 09:54
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small comment :p

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the nf-core module some time in the future? It would be a nice addition :p

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking about it (already open an issue). But then I realised it is possible to create feature tables inside sompy. I am not sure now.. what do you think?

Copy link
Contributor Author

@kubranarci kubranarci May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To understand better you can check how I use sompy module here: conf/modules.config

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with somatic data (sorry), but it doesn't really matter to me how you do it as long as it works 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D Yea. I will have a thought if the module needed.. Thanks for the review!!

@kubranarci kubranarci merged commit 2f49694 into dev May 29, 2024
4 checks passed
@kubranarci kubranarci deleted the 41-somatic-benchmarking branch May 29, 2024 10:07
@kubranarci kubranarci linked an issue May 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

somatic benchmarking implement SEQC2 data
2 participants