Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified date of vocabulary lost #147

Closed
dalito opened this issue Aug 11, 2023 · 1 comment · Fixed by #148
Closed

Modified date of vocabulary lost #147

dalito opened this issue Aug 11, 2023 · 1 comment · Fixed by #148
Labels
bug Something is not working as expected.
Milestone

Comments

@dalito
Copy link
Member

dalito commented Aug 11, 2023

@nmoust - FYI

In nfdi4cat/voc4cat#12 the "modified date" present in the submitted Excel file was lost in the conversion to SKOS. The SKOS concept scheme uses the same value for "modified date" as for "created date". This may be a bug in the convert sub-cmd.

@dalito dalito added the bug Something is not working as expected. label Aug 11, 2023
@dalito dalito added this to the 0.6.3 milestone Aug 11, 2023
@dalito dalito changed the title Modified date of vocabbulary lost Modified date of vocabulary lost Aug 11, 2023
@dalito
Copy link
Member Author

dalito commented Aug 14, 2023

This behavior comes from the code merged from vocexcel. It uses the attribute created if a modified date is present (which seems like a bug). Interestingly no one noticed this until now. A fix is to simply use the modified attribute instead.

However, we should take the chance to re-consider how we want to keep date/version in Excel/rdf and git-tags automatically in sync instead of relying on a version/date entered in Excel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant