Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modified date handling; add env.var support for version. #148

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

dalito
Copy link
Member

@dalito dalito commented Aug 14, 2023

  • Support for two environment variables was added. Both changes enable achieving consistent version/tag info in the gh-based vocabulary management (related Finalize deployment to gh-pages voc4cat-template#11).
    • VOC4CAT_MODIFIED - Can be used to supply a modified date. If present it will be used with highest preference.
    • VOC4CAT_VERSION - version string; it must start with "v". If present this version has highest precedence.
  • In the concept scheme sheet in xlsx, version strings must start with "v", too. This prevents that Excel auto-format modifies the version string by falsely interpreting the version as date or number.
  • The version string and the modified date are now optional. Tracking version or modified date in the code that is under git control does not make much sense. This info should be only added in the release step.

This PR also fixes the link to the RDF-file in pylode-docs.

Closes #147

@dalito dalito added bug Something is not working as expected. enhancement Request for changing or improving existing features labels Aug 14, 2023
@dalito dalito added this to the 0.6.3 milestone Aug 14, 2023
@dalito dalito self-assigned this Aug 14, 2023
@dalito dalito merged commit 0754e3c into main Aug 16, 2023
@dalito dalito deleted the issue147 branch August 16, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected. enhancement Request for changing or improving existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modified date of vocabulary lost
1 participant