Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixes defined in id_ranges.toml are ignored #257

Closed
dalito opened this issue Jan 28, 2025 · 0 comments · Fixed by #263
Closed

Prefixes defined in id_ranges.toml are ignored #257

dalito opened this issue Jan 28, 2025 · 0 comments · Fixed by #263
Assignees
Labels
bug Something is not working as expected.
Milestone

Comments

@dalito
Copy link
Member

dalito commented Jan 28, 2025

Observed in v0.8.8 while working on #253: The prefixes are read in correctly from the config file but are later overwritten later by the default rdflib prefixes. As a result, the code always writes IRIs to Excel (for the voc4cat vocabulary). But even now in 0.8.x it should write CURIEs instead of IRIs, but no one noticed.

Instead of just fixing this, we will also make the prefixes sheet read only in v0.9.0. Keeping id editable makes no sense, since

  • all user-made additions will always be lost in the xlsx -> rdf -> xlsx conversion,
  • the ´xlsx´ that is downloaded to make new contribution has to be always be the same for all users.

The better way to define additional prefixes is to add them to idranges.toml in a PR to the vocabulary repository. This way they are shared with all users and survive all conversions.

This will be part of 0.9.0. The idea to make the prefixes sheet read-only is coming from the ideas collection for 1.0.0 (#124).

@dalito dalito added the bug Something is not working as expected. label Jan 28, 2025
@dalito dalito added this to the 0.9.0 milestone Jan 28, 2025
@dalito dalito self-assigned this Jan 28, 2025
@dalito dalito moved this from New to To Do (<2 weeks) in Voc4Cat cross-repo view Jan 28, 2025
@dalito dalito moved this from To Do (<2 weeks) to In progress in Voc4Cat cross-repo view Jan 28, 2025
@dalito dalito moved this from In progress to To Do (<2 weeks) in Voc4Cat cross-repo view Jan 29, 2025
@dalito dalito moved this from To Do (<2 weeks) to In progress in Voc4Cat cross-repo view Jan 29, 2025
@github-project-automation github-project-automation bot moved this from In progress to Completed in Voc4Cat cross-repo view Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected.
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

1 participant