Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photocatalysis vocabulary #5

Merged
merged 19 commits into from
Jun 30, 2023
Merged

Conversation

nmoust
Copy link
Collaborator

@nmoust nmoust commented Apr 20, 2023

This is a version of the vocabulary for photocatalysis (not CO2 reduction specific). The vocabulary is restructured (some new concepts added, new parent - children relations). The template from nfdi4cat/voc4cat was used. IRIs were added manually.

Closes #2

nmoust and others added 11 commits April 20, 2023 14:11
This is a version of the vocabulary for photocatalysis (not CO2 reduction specific). The vocabulary is restructured (some new concepts added, new parent - children relations). The template from nfdi4cat/voc4cat was used. IRIs were added manually.
This is a version of the vocabulary for photocatalysis (not CO2 reduction specific). The vocabulary is restructured (some new concepts added, new parent - children relations). The template from nfdi4cat/voc4cat was used. IRIs were added manually.
This is a version of the vocabulary for photocatalysis (not CO2 reduction specific). The vocabulary is restructured (some new concepts added, new parent - children relations). The template from nfdi4cat/voc4cat was used. IRIs were added manually.
This is a version of the vocabulary for photocatalysis (not CO2 reduction specific). The vocabulary is restructured (some new concepts added, new parent - children relations). The template from nfdi4cat/voc4cat was used. IRIs were added manually.
This is a version of the vocabulary for photocatalysis (not CO2 reduction specific). The vocabulary is restructured (some new concepts added, new parent - children relations). The template from nfdi4cat/voc4cat was used. IRIs were added manually.
@dalito dalito mentioned this pull request May 22, 2023
@dalito dalito mentioned this pull request Jun 29, 2023
@dalito
Copy link
Member

dalito commented Jun 29, 2023

There was a bug in vocexcel (nfdi4cat/VocExcel#8) which made the pipeline pass although the Excel-vocabulary still had errors. I fixed the issue in nfdi4cat/VocExcel#9.

Please remove the problematic ";" in the ChildrenIRIs and submit the vocabulary file again. Sorry for the trouble.

nmoust and others added 2 commits June 30, 2023 09:12
This includes the updated voc4cat file, correcting a '';'' appearing in the Children IRIs column.
Copy link
Member

@dalito dalito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will update the concept scheme url to its final location later.

@dalito dalito merged commit ccecac6 into nfdi4cat:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic photo-catalysis vocabulary
2 participants