refactor(ngx-control-value-accessor): use normal effect instead of rxEffect #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobbyRabbitman can you rebase this please? And make it ready for review if there's nothing else you want to add. Thanks. |
RobbyRabbitman
force-pushed
the
refactor/control-value-accessor-signal-usage
branch
from
49ef058 to
3346cdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rxEffect was just used in order to 'escape' setting signals in an effect back then when it was not allowed... this can be done now anyways and could have been done back then aswell, but I did not know at that time about the usage of a normal effect and untracked.
wait for #555