Minor fixes in nifgen metadata #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 86.99% 86.99%
=======================================
Files 10 10
Lines 1746 1746
=======================================
Hits 1519 1519
Misses 227 227Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 86.99% 86.99%
=======================================
Files 10 10
Lines 1746 1746
=======================================
Hits 1519 1519
Misses 227 227Continue to review full report at Codecov.
|
marcoskirsch
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
configure_custom_fir_filter_coefficients()- Should have been removed by Disable nifgen get_fir_filter_coefficients() #891get_fir_filter_coefficients()to use 'ivi-dance-with-a-twist' instead of hand maintained function - not used yet since OSP is not in public APIList issues fixed by this Pull Request below, if any.
What testing has been done?