-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up nitclk docs #1043
Merged
Merged
Clean up nitclk docs #1043
Changes from all commits
Commits
Show all changes
132 commits
Select commit
Hold shift + click to select a range
08fc91a
Add initial metadata
texasaggie97-zz 9d53c62
Create nitclk.mak
texasaggie97-zz 39c2ed7
Remove numpy restriction
texasaggie97-zz 571206f
Upgrade pip
texasaggie97-zz b7732eb
Remove specific version of flake8
texasaggie97-zz 41cf6ca
Add basepython section
texasaggie97-zz e074561
Try using pypy3.5
texasaggie97-zz defd961
Go back to pypy3 and remove basepython block
texasaggie97-zz ae86324
Don't need to run build_test for all builds - only 3.6
texasaggie97-zz 5a97c42
Remove warning from coverage
texasaggie97-zz ef21c76
Undo previous change
texasaggie97-zz 143e08f
Try disabling faulthandler
texasaggie97-zz 3673d09
Remove --no-faulthandler
texasaggie97-zz f1ae55d
pypy needs an older version of pytest
texasaggie97-zz a4a28fa
Use platform_python_implementation since implementation_name is not d…
texasaggie97-zz 1251734
Try to get back to the initial coverage
texasaggie97-zz b3005f0
Do the same thing for build_test
texasaggie97-zz b6b5a30
Remove redundant pip
texasaggie97-zz d8f4566
Merge branch 'clean_tox' into add_tclk/metadata
texasaggie97-zz 5e4c3da
Merge branch 'add_tclk/metadata' into add_tclk/simple_codegen
texasaggie97-zz 8fd761d
Add codecov file to try to control limits for passing
texasaggie97-zz 8052328
Merge branch 'clean_tox' into build/codecov
texasaggie97-zz d7f5f9c
Merge branch 'build/codecov' into add_tclk/metadata
texasaggie97-zz 09cac06
Merge branch 'add_tclk/metadata' into add_tclk/simple_codegen
texasaggie97-zz d84d22f
Enable nitclk build
texasaggie97-zz b135799
There are some files we will need to skip for now
texasaggie97-zz b1f3290
Add generated nitclk files
texasaggie97-zz c31a6b4
Update generated files
texasaggie97-zz 7baef6a
Can't skip README.rst
texasaggie97-zz f05da64
Update templates
texasaggie97-zz 31d1509
Add new cases for buffers with a converter
texasaggie97-zz 95c96da
Need to handle ' []' to normalize everything
texasaggie97-zz 0ac90fa
Get the session handle name from config instead of hardcoding 'vi'
texasaggie97-zz 7ab3975
Temp commit
texasaggie97-zz 76c608e
Fix syntax error
texasaggie97-zz 0d71be0
Test new cases
texasaggie97-zz cabe80f
Merge branch 'master' into add_tclk/simple_codegen
texasaggie97-zz c6e0a7c
Force change
texasaggie97-zz a40e9c5
Update generated files
texasaggie97-zz 3afc75e
Merge branch 'master' into add_tclk/simple_codegen
texasaggie97-zz f8eda3f
Update generated files
texasaggie97-zz af28fc7
Merge branch 'add_tclk/simple_codegen' into add_tclk/codegen_changes
texasaggie97-zz 22890c1
Add different target for pr (project) and commit (patch)
texasaggie97-zz ea12f9b
threshold should be number
texasaggie97-zz b040199
Renumber scaler cases to be in order used in the code
texasaggie97-zz 37b11e0
Update generated files
texasaggie97-zz 4b1082b
Renumber buffer cases to match order used in code
texasaggie97-zz 30bc0ce
Move and rename test to match case (C020)
texasaggie97-zz 4d3ae50
Merge branch 'master' into add_tclk/fix_case_sequence
texasaggie97-zz 5534ccf
Merge branch 'master' into add_tclk/nitclk_template_changes
texasaggie97-zz 7b37c71
Merge branch 'add_tclk/fix_case_sequence' into add_tclk/nitclk_templa…
texasaggie97-zz 24bd847
Update generated files
texasaggie97-zz 5650e56
Merge branch 'master' into add_tclk/nitclk_template_changes
texasaggie97-zz a65cc12
Add nitclk specific session template
texasaggie97-zz 70f9dbb
No longer need to skip generating session.py
texasaggie97-zz aea6f50
Add new session.py
texasaggie97-zz cfe8ab3
Add placeholder nitclk example
texasaggie97-zz 5a0be07
Enable example documentation build
texasaggie97-zz 8e55771
Add generated examples.rst
texasaggie97-zz 31f64c5
Merge branch 'add_tclk/add_example' into add_tclk/enable_documentation
texasaggie97-zz 4b8e30d
Add TClk to static files
texasaggie97-zz 3ce9738
Add tclk to index
texasaggie97-zz cde1321
Add tclk top level file
texasaggie97-zz 62bdd35
Update generated files
texasaggie97-zz 9bf949f
Merge branch 'add_tclk/add_example' into add_tclk/enable_unit_tests
texasaggie97-zz 7f5cc84
Add VIUInt32 matcher
texasaggie97-zz 2d5fcd7
Add ViSession buffer matcher
texasaggie97-zz 82d38b1
We want to look at all of nitclk since there are differences in some …
texasaggie97-zz 16930df
Run unit tests on nitclk
texasaggie97-zz d3a55f1
Add initial test and setup
texasaggie97-zz d46ca98
Update generated files
texasaggie97-zz c70a6ef
Correct wrong exception
texasaggie97-zz 48ff943
Rename test
texasaggie97-zz 0ca1883
Add return (helps editor auto formatting)
texasaggie97-zz 115def3
Update generated files
texasaggie97-zz d17e564
Merge branch 'master' into add_tclk/enable_unit_tests
texasaggie97-zz ca2945a
Few more tests
texasaggie97-zz 2efed70
Merge branch 'master' into add_tclk/more_unit_tests
texasaggie97-zz af60acd
Add new filter type
texasaggie97-zz ad87c3f
Don't try to use a singleton any more - didn't work
texasaggie97-zz bad37ba
Use new filter type
texasaggie97-zz 0f984d6
All API functions tested
texasaggie97-zz 963cce3
Update generated files
texasaggie97-zz f3ea8a1
Fix metadata for GetAttributeViString
texasaggie97-zz eb7bacd
More tests!
texasaggie97-zz f9192aa
Correct type is ViSession
texasaggie97-zz 7fd2646
Need to say it isn't the session handle
texasaggie97-zz dd909cd
Test class for testing session number converter
texasaggie97-zz 66eb066
Additional tests
texasaggie97-zz e3232a4
Update generated files
texasaggie97-zz 2791d07
Merge branch 'master' into add_tclk/more_unit_tests
texasaggie97-zz 2ddaeee
We don't need to measure anything from nitclk or nimodinst other than…
texasaggie97-zz a7c43e0
Fix class names to work with pytest
texasaggie97-zz 4f89b1f
Use correct name
texasaggie97-zz 3b0a016
Don't codegen ViBoolean functions since they aren't actually used
texasaggie97-zz 667dad8
Update generated files
texasaggie97-zz f17b516
Handle not having an 'init_function' in config
texasaggie97-zz b79407c
Remove InitForDocumentation
texasaggie97-zz 7ae9806
Add tclk specific class.rst template
texasaggie97-zz 83dfb8d
Updates
texasaggie97-zz 167507e
Build using nitclk specific class.rst template
texasaggie97-zz e887d1f
Add type in documentation
texasaggie97-zz 5ddf7d8
Fix output path
texasaggie97-zz b4325f7
Documentation updates
texasaggie97-zz 366d3f2
Merge branch 'add_tclk/enable_documentation' into add_tclk/update_docs
texasaggie97-zz 3d8cbf1
We need to be able to use method or function, default is method
texasaggie97-zz 11ca67b
Links need to be different for nitclk
texasaggie97-zz a713587
Clean up nitclk class documentation
texasaggie97-zz c6392f9
Update generated files
texasaggie97-zz 3df99d6
Merge branch 'master' into add_tclk/update_docs
texasaggie97-zz 88013cf
Update generated files
texasaggie97-zz 04eb58b
Merge branch 'master' into add_tclk/more_unit_tests
texasaggie97-zz c8fbbdc
Use the session name from config - doesn't always match the parameter…
texasaggie97-zz 5feb02e
Update converter name
texasaggie97-zz 4374630
Need a reperated capabilities for get/set attribute
texasaggie97-zz cf16bf2
Function is now private
texasaggie97-zz 8e500bc
Update generated files
texasaggie97-zz 7bb51fd
Merge branch 'add_tclk/more_unit_tests' into add_tclk/update_docs
texasaggie97-zz 912c370
Update
texasaggie97-zz 3947ebe
Remove extraneous comment
texasaggie97-zz 0d6a364
Only add properties section if there are actually properties
texasaggie97-zz 5eb21b3
Update to match latest format in master
texasaggie97-zz be1e02a
Update generated files
texasaggie97-zz ca4be07
Use the entire navigation depth
texasaggie97-zz 08ce4c5
Merge branch 'master' into add_tclk/update_docs
texasaggie97-zz 21a7745
Remove unused parameter
texasaggie97-zz 219c8c5
Clarify docstring
texasaggie97-zz 7a96828
Fix example code to actually work
texasaggie97-zz 04e3984
Update NI-TClk description
texasaggie97-zz a8243bf
Update generated files
texasaggie97-zz fa53c27
Lower target for patch
texasaggie97-zz 78308ce
Merge branch 'master' into add_tclk/update_docs
texasaggie97-zz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ coverage: | |
threshhold: 5 | ||
patch: | ||
default: | ||
target: 85% | ||
target: 70% | ||
threshhold: 5 | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty uncomfortable adding conditional logic based on specific module names to the code-generator logic.
We should really try to keep this generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How? What can we key on instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If driver config had:
Could we then make better reuse of the templates and get rid of this conditional logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but to quote a top notch engineer from a different review "The medicine is worse than the disease".
It would remove using 'nitclk' in the conditionals here (but not remove them), and
session.py.mako
would become much more complicated and less easy to follow with the conditionals there surrounding large blocks of code.And I don't think it would be enough to combine the nitclk session.py.mako with the generic one. Or if it is, it would become even more complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels very wrong and hacky, but I can see it being the pragmatic solution. At least we tried.