-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fancy fetch capture waveform #1112
Add fancy fetch capture waveform #1112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 20 20
Lines 3679 3679
=======================================
Hits 3311 3311
Misses 368 368 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. If you can address them or strongly want to push back, feel free to drop and merge.
Comments addressed
src/nidigital/templates/session.py/fancy_fetch_capture_waveform.py.mako
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm nervous about sourcing _fetch_capture_waveform
. I wish there was a clever way to get it to work with the code-generator without major rework.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
fetch_capture_waveform_u32()
List issues fixed by this Pull Request below, if any.
What testing has been done?