Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fancy fetch capture waveform #1112

Merged
merged 23 commits into from
Nov 18, 2019

Conversation

texasaggie97-zz
Copy link
Contributor

@texasaggie97-zz texasaggie97-zz commented Nov 12, 2019

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • Visual inspection

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #1112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1112   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files          20       20           
  Lines        3679     3679           
=======================================
  Hits         3311     3311           
  Misses        368      368

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f795c...1487c23. Read the comment docs.

Copy link
Member

@marcoskirsch marcoskirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. If you can address them or strongly want to push back, feel free to drop and merge.

@texasaggie97-zz texasaggie97-zz dismissed stale reviews from sbethur and marcoskirsch November 12, 2019 22:00

Comments addressed

Copy link
Member

@marcoskirsch marcoskirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nervous about sourcing _fetch_capture_waveform. I wish there was a clever way to get it to work with the code-generator without major rework.

@marcoskirsch marcoskirsch merged commit 8dec25f into master Nov 18, 2019
@marcoskirsch marcoskirsch deleted the bug1076/add_fancy_fetch_capture_waveform branch November 18, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch_capture_waveform_u32 missing in nidigital API nidigital fetch_capture_waveform_u32 returns empty list
3 participants