Add fancy write_source_waveform_unique #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
=========================================
- Coverage 91.38% 89.99% -1.4%
=========================================
Files 20 20
Lines 3623 3679 +56
=========================================
Hits 3311 3311
- Misses 312 368 +56
Continue to review full report at Codecov.
|
sbethur
previously requested changes
Nov 14, 2019
sbethur
approved these changes
Nov 15, 2019
texasaggie97-zz
changed the title
marcoskirsch
previously requested changes
Nov 18, 2019
sbethur
previously requested changes
Nov 18, 2019
src/nidigital/templates/session.py/fancy_write_source_waveform_site_unique.py.mako
Outdated
Show resolved
Hide resolved
sbethur
approved these changes
Nov 19, 2019
marcoskirsch
approved these changes
Nov 19, 2019
| 'description': '\nDictionary where each key is the site number and the value is array.array of unsigned int\n' | ||
| }, | ||
| 'name': 'waveform_data', | ||
| 'type': 'ViUInt32', |
There was a problem hiding this comment.
If this is ignored because "python-only" please add a comment.
texasaggie97-zz
deleted the
bug1069/add_fancy_write_source_waveform_unique
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
write_source_waveform_unique()List issues fixed by this Pull Request below, if any.
What testing has been done?