Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chained repeated capabilities #1291

Merged
merged 20 commits into from
Mar 26, 2020
Merged

Support chained repeated capabilities #1291

merged 20 commits into from
Mar 26, 2020

Conversation

texasaggie97-zz
Copy link
Contributor

@texasaggie97-zz texasaggie97-zz commented Feb 25, 2020

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • You can now chain repeated capabilities
    session.sites[0, 1].pins['PinA', 'PinB'].ppmu_voltage_level = 4
    will pass in 'site0/PinA,site0/PinB,site1/PinA,site1/PinB' as the repeated capabilities string
  • Any repeated capabilities can be chained, so it is up to the driver to return an error if an invalid chaining is passed into the driver
  • Moved repeated capabilities to _SessionBase()
  • _RepeatedCapabilities() class now takes the current repeated capabilities as a list and uses it to expand with the new list

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • Unit tests have been added

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #1291 into master will decrease coverage by 4.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
- Coverage   91.52%   87.27%   -4.25%     
==========================================
  Files          20       29       +9     
  Lines        3668     6445    +2777     
==========================================
+ Hits         3357     5625    +2268     
- Misses        311      820     +509
Flag Coverage Δ
#codegenunittests 87.76% <ø> (ø) ⬆️
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 51.72% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 96.07% <100%> (+0.01%) ⬆️
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 95.99% <100%> (+0.01%) ⬆️
#niscopesystemtests 83.15% <ø> (?)
#nisesystemtests 100% <ø> (?)
#niswitchsystemtests 98.11% <ø> (?)
#nitclksystemtests 100% <ø> (?)
#nitclkunittests 95.92% <100%> (ø) ⬆️
Impacted Files Coverage Δ
generated/nifake/nifake/session.py 97.61% <100%> (+0.01%) ⬆️
generated/nidcpower/nidcpower/_library.py 98.58% <0%> (ø)
generated/niswitch/niswitch/_library.py 98.11% <0%> (ø)
generated/niscope/niscope/_library.py 86.69% <0%> (ø)
generated/nimodinst/nimodinst/_library.py 87.23% <0%> (ø)
generated/nise/nise/_library.py 100% <0%> (ø)
generated/niscope/niscope/waveform_info.py 57.35% <0%> (ø)
generated/nidmm/nidmm/_library.py 95.48% <0%> (ø)
generated/nidigital/nidigital/_library.py 51.72% <0%> (ø)
generated/nitclk/nitclk/_library.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8603487...e037f67. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #1291 into master will decrease coverage by 5.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
- Coverage   91.52%   86.46%   -5.06%     
==========================================
  Files          20       27       +7     
  Lines        3668     6015    +2347     
==========================================
+ Hits         3357     5201    +1844     
- Misses        311      814     +503
Flag Coverage Δ
#codegenunittests 87.76% <ø> (ø) ⬆️
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 51.72% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 96.07% <100%> (+0.01%) ⬆️
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 95.99% <100%> (+0.01%) ⬆️
#niscopesystemtests 83.15% <ø> (?)
#nitclksystemtests 100% <ø> (?)
#nitclkunittests 95.92% <100%> (ø) ⬆️
Impacted Files Coverage Δ
generated/nifake/nifake/session.py 97.61% <100%> (+0.01%) ⬆️
generated/nidcpower/nidcpower/_library.py 98.58% <0%> (ø)
generated/niscope/niscope/_library.py 86.69% <0%> (ø)
generated/nimodinst/nimodinst/_library.py 87.23% <0%> (ø)
generated/niscope/niscope/waveform_info.py 57.35% <0%> (ø)
generated/nidmm/nidmm/_library.py 95.48% <0%> (ø)
generated/nidigital/nidigital/_library.py 51.72% <0%> (ø)
generated/nitclk/nitclk/_library.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8603487...e037f67. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #1291 into master will increase coverage by 4.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
+ Coverage   91.84%   96.10%   +4.26%     
==========================================
  Files          20       10      -10     
  Lines        3616     1669    -1947     
==========================================
- Hits         3321     1604    -1717     
+ Misses        295       65     -230     
Flag Coverage Δ
#codegenunittests ?
#nifakeunittests 96.31% <100.00%> (+0.01%) ⬆️
#nimodinstunittests 96.20% <100.00%> (+0.18%) ⬆️
#nitclkunittests 96.10% <100.00%> (+0.16%) ⬆️
Impacted Files Coverage Δ
generated/nifake/nifake/session.py 97.67% <100.00%> (+0.01%) ⬆️
build/helper/metadata_find.py
build/helper/parameter_usage_options.py
build/helper/codegen_helper.py
build/helper/metadata_merge_dicts.py
build/helper/documentation_helper.py
build/helper/helper.py
build/helper/documentation_snippets.py
build/helper/metadata_filters.py
build/helper/__init__.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4f1b2...9b4b895. Read the comment docs.

@texasaggie97-zz texasaggie97-zz dismissed sbethur’s stale review March 4, 2020 23:47

Comments addressed

@texasaggie97-zz texasaggie97-zz dismissed sbethur’s stale review March 19, 2020 16:23

Comments addressed

Copy link
Member

@marcoskirsch marcoskirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small wording change requested, then feel free to merge.

@texasaggie97-zz texasaggie97-zz changed the title Support nested repeated capabilities Support chained repeated capabilities Mar 26, 2020
@sbethur sbethur merged commit db75863 into master Mar 26, 2020
@sbethur sbethur deleted the nested-rep-caps branch March 26, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants