-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support chained repeated capabilities #1291
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
==========================================
- Coverage 91.52% 87.27% -4.25%
==========================================
Files 20 29 +9
Lines 3668 6445 +2777
==========================================
+ Hits 3357 5625 +2268
- Misses 311 820 +509
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
==========================================
- Coverage 91.52% 86.46% -5.06%
==========================================
Files 20 27 +7
Lines 3668 6015 +2347
==========================================
+ Hits 3357 5201 +1844
- Misses 311 814 +503
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
==========================================
+ Coverage 91.84% 96.10% +4.26%
==========================================
Files 20 10 -10
Lines 3616 1669 -1947
==========================================
- Hits 3321 1604 -1717
+ Misses 295 65 -230
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small wording change requested, then feel free to merge.
What does this Pull Request accomplish?
'site0/PinA,site0/PinB,site1/PinA,site1/PinB'
as the repeated capabilities string_SessionBase()
_RepeatedCapabilities()
class now takes the current repeated capabilities as a list and uses it to expand with the new listList issues fixed by this Pull Request below, if any.
nidigital
should expose sites as repeated capabilities #1111What testing has been done?