Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nidigital API methods to use pins repeated capability #1306

Merged
merged 3 commits into from
Mar 3, 2020

Conversation

sbethur
Copy link
Contributor

@sbethur sbethur commented Mar 3, 2020

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Following methods are updated such that pins repeated capability can be used on them:

configure_time_set_compare_edges_strobe
configure_time_set_compare_edges_strobe2x
configure_time_set_drive_edges
configure_time_set_drive_edges2x
configure_time_set_drive_format
configure_time_set_edge
configure_time_set_edge_multiplier
create_capture_waveform_parallel
create_capture_waveform_serial
create_source_waveform_parallel
create_source_waveform_serial
fetch_history_ram_cycle_information
get_time_set_drive_format
get_time_set_edge
get_time_set_edge_multiplier

List issues fixed by this Pull Request below, if any.

What testing has been done?

A new system test is added to verify pins can be used as repeated capability.

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1306 into master will decrease coverage by 3.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
- Coverage   91.52%   88.46%   -3.06%     
==========================================
  Files          20       31      +11     
  Lines        3668     7055    +3387     
==========================================
+ Hits         3357     6241    +2884     
- Misses        311      814     +503
Flag Coverage Δ
#codegenunittests 87.76% <ø> (ø) ⬆️
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 56.51% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 96.06% <ø> (ø) ⬆️
#nifgensystemtests 96.91% <ø> (?)
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 95.98% <ø> (ø) ⬆️
#niscopesystemtests 83.15% <ø> (?)
#nisesystemtests 100% <ø> (?)
#niswitchsystemtests 98.11% <ø> (?)
#nitclksystemtests 100% <ø> (?)
#nitclkunittests 95.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
generated/nidcpower/nidcpower/_library.py 98.58% <0%> (ø)
generated/nifgen/nifgen/_library.py 96.91% <0%> (ø)
generated/niswitch/niswitch/_library.py 98.11% <0%> (ø)
generated/niscope/niscope/_library.py 86.69% <0%> (ø)
generated/nimodinst/nimodinst/_library.py 87.23% <0%> (ø)
...digital/nidigital/history_ram_cycle_information.py 100% <0%> (ø)
generated/nise/nise/_library.py 100% <0%> (ø)
generated/niscope/niscope/waveform_info.py 57.35% <0%> (ø)
generated/nidmm/nidmm/_library.py 95.48% <0%> (ø)
generated/nidigital/nidigital/_library.py 54.84% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1424535...1a6daf5. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1306 into master will increase coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
+ Coverage   91.52%   92.48%   +0.96%     
==========================================
  Files          20       22       +2     
  Lines        3668     4218     +550     
==========================================
+ Hits         3357     3901     +544     
- Misses        311      317       +6     
Flag Coverage Δ
#codegenunittests 87.76% <ø> (ø) ⬆️
#nidcpowersystemtests 98.58% <ø> (?)
#nifakeunittests 96.06% <ø> (ø) ⬆️
#nimodinstunittests 95.98% <ø> (ø) ⬆️
#nitclksystemtests 100.00% <ø> (?)
#nitclkunittests 95.76% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
generated/nidcpower/nidcpower/_library.py 98.58% <0.00%> (ø)
generated/nitclk/nitclk/_library.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1424535...1a6daf5. Read the comment docs.

@marcoskirsch marcoskirsch merged commit 5b87119 into master Mar 3, 2020
@marcoskirsch marcoskirsch deleted the bug1294/nidigital_pins_rep_cap branch March 3, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update methods in nidigital API to be Pins repeated-capability-based, where applicable
2 participants