Improve usability of get_site_pass_fail by returning dict - site: pass_fail #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 20 20
Lines 3616 3616
=======================================
Hits 3321 3321
Misses 295 295
Continue to review full report at Codecov.
|
marcoskirsch
previously requested changes
Mar 18, 2020
src/nidigital/templates/session.py/fancy_get_site_pass_fail.py.mako
Outdated
Show resolved
Hide resolved
src/nidigital/templates/session.py/fancy_get_site_pass_fail.py.mako
Outdated
Show resolved
Hide resolved
src/nidigital/templates/session.py/fancy_get_site_pass_fail.py.mako
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
marcoskirsch
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request
What does this Pull Request accomplish?
Improve usability of
get_site_pass_failby returning dict -site(int):pass_fail(bool)List issues fixed by this Pull Request below, if any.
What testing has been done?
Updated system test that calls
get_site_pass_fail