-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usage of datetime
library types with hightime
types
#1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the type of applicable properties and method parameters from `datetime.timedelta` to `hightime.timedelta` and from `datetime.datetime` to `hightime.datetime`.
3 tasks
# Conflicts: # build/templates/setup.py.mako
Codecov Report
@@ Coverage Diff @@
## master #1449 +/- ##
==========================================
+ Coverage 91.92% 93.37% +1.44%
==========================================
Files 20 25 +5
Lines 3655 5177 +1522
==========================================
+ Hits 3360 4834 +1474
- Misses 295 343 +48
Continue to review full report at Codecov.
|
marcoskirsch
previously requested changes
May 15, 2020
…tetime.timedelta`
marcoskirsch
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request
What does this Pull Request accomplish?
In all nimi-python modules, change the type of applicable properties and method parameters from
datetime.timedelta
tohightime.timedelta
and fromdatetime.datetime
tohightime.datetime
.hightime
types are drop-in replacements fordatetime
counterparts, with sub-microsecond resolution. See #1445 (comment) for the rationale behind this change.hightime
typeshightime
typeshightime
typesList issues fixed by this Pull Request below, if any.
What testing has been done?
Update unit tests for converter and nifake to verify usage of
hightime
types. CI runs all the tests.