-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for repeated capabilities on methods that support independent channels #1589
Add support for repeated capabilities on methods that support independent channels #1589
Conversation
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 20 20
Lines 3463 3463
=======================================
Hits 3175 3175
Misses 288 288
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ok to test |
We need system tests to validate calling the updated entry points with rep caps. Please add a link or work item number in which that will be done. |
@ni-erikcrank please re-run codegen and we'll merge. |
Why not in the same PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting system test changes
System tests would not succeed until we have a constructor that allows creation of sessions with independent channels. I didn't want to submit failing system tests. |
I think they would, if you pass something equivalent to "all the channels in the session" such as |
Let me know if you are still awaiting changes/actions from me. |
There are merge conflicts you need to resolve. |
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestThe repeated capabilities functionality of attributes and methods will be tested after independent channels session constructor is implemented. System tests will be added as part of this Azure DevOps work item.
What does this Pull Request accomplish?
Adds repeated capabilities to methods that support independent channels.
List issues fixed by this Pull Request below, if any.
What testing has been done?
Verified that DCPower system tests pass.