-
Notifications
You must be signed in to change notification settings - Fork 72.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build of current dev is failing on Heroku #7475
Comments
Same here, cgm-remote-monitor/package-lock.json specifies darwin as the OS and that's not what's Heroku wants... |
npm ls fsevent didn't list any output. I'm running on linux, and regenerating this file after removing it seems to remove the fsevent package from the file. It's likely that fsevent may be used in development mode as part of one of the build utilities, but it shouldn't block anyone from deploying. #7475
As discussed with Ben in private, the issue seems to be the lock file in the repo has been generated with a newer version of npm than the npm version in package.json. Heroku honors the defined node and npm versions, which then fail to interpret the file in the repo |
I've removed the |
We should be able to remove Node 10 and 12 from the officially supported versions, as these are not maintained anymore. OpenJS lists Node 14 as the Maintenance LTS version: https://nodejs.org/en/about/releases/ |
Node 10, 12, and 14 produce identical package-lock.json files using npm 6. |
Should be resolved. |
npm ls fsevent didn't list any output. I'm running on linux, and regenerating this file after removing it seems to remove the fsevent package from the file. It's likely that fsevent may be used in development mode as part of one of the build utilities, but it shouldn't block anyone from deploying. nightscout#7475
npm ls fsevent didn't list any output. I'm running on linux, and regenerating this file after removing it seems to remove the fsevent package from the file. It's likely that fsevent may be used in development mode as part of one of the build utilities, but it shouldn't block anyone from deploying. nightscout#7475
Describe the bug
From log of build attempt:
The text was updated successfully, but these errors were encountered: