-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Refactor data representation structures for multimodality #52
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 65.85% 67.60% +1.75%
==========================================
Files 19 20 +1
Lines 943 991 +48
Branches 121 131 +10
==========================================
+ Hits 621 670 +49
+ Misses 277 267 -10
- Partials 45 54 +9 ☔ View full report in Codecov by Sentry. |
f95ad95
to
f305783
Compare
ddb86b8
to
5af5f21
Compare
11021b6
to
a8db7eb
Compare
a8db7eb
to
8298746
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the sake of moving forward: comments can be addressed in a separate PR.
So this means I will need to fix all conflicts in PR #28 😭.
Thanks for this, thanks for the notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of thoughts about whether we want something more generic for the stored affines. But I have not thought this through very deeply.
f81f85e
to
e533ff5
Compare
Co-Authored-By: Jon Haitz Legarreta Gorroño <[email protected]>
Thanks. |
Proposes a new
nifreeze.data.base.BaseDataset
class with minimal metadata shared across modalities. Modality-wise data representation classes should derive from this one and extend the necessary behaviors (e.g., indexed access).I believe this approach would be cleaner to have a common interface. Models can be more specific in the required data structures they handle.
By adding indexing, the dataset can be split with fancy indexing, but returning a tuple containing the split across data AND metadata. This will allow transparent splits within models.
Resolves: #19.