Add RAC outpost #48
Open
Add RAC outpost #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dminuoso
force-pushed
the
add-rac-outpost
branch
from
989b139 to
b74b3f0
Compare
Ma27
reviewed
Mar 9, 2025
| ExecStart = "${config.services.authentik.authentikComponents.gopkgs}/bin/rac"; | ||
| EnvironmentFile = mkIf (cfg.environmentFile != null) [ cfg.environmentFile ]; | ||
| Restart = "on-failure"; | ||
| BindReadOnlyPaths = "${lib.getExe pkgs.guacamole-server}:/opt/guacamole/sbin/guacd"; |
There was a problem hiding this comment.
I think it's more reasonable to just patch the path int he source code given we're compiling the stuff ourselves already.
We have quite a large closure already, so I'd just do it by default it and see if somebody complains.
This has the side-effect this is also usable outside of the unit.
There was a problem hiding this comment.
You can already run it outside the unit with systemd-run, plus it just seems a bit more effort to create and maintain a patch for an exceedingly unlikely case.
But I do not feel strongly about this, if you prefer I'll make it a patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Seems to work fine.
One point of interest,
services.authentik-rac.enablewould conflict withservices.guacamole-server.enablebecause authentik-rac starts and managesguacdinternally. We could perhaps mkForce the latter to false?