-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
herbstluftwm extraconfig dose not support bash functions #5213
Comments
Hi @tincotema, sorry for the late reply. The point of that alias and only executing all commands at once with the But I can see how it can be annoying if you want to use bash functions in your autostart file. I'll create a PR to make this optional like you suggested. |
Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting. If you are the original author of the issue
If you are not the original author of the issue
Memorandum on closing issuesDon't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort. |
Still relevant, there is a PR at #5566 but it hasn't been merged yet. |
Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting. If you are the original author of the issue
If you are not the original author of the issue
Memorandum on closing issuesDon't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort. |
Still relevant, previously mentioned PR is still good but hasn't been merged yet. |
Are you following the right branch?
Is there an existing issue for this?
Issue description
Hi, i am in the process of porting my existing herbstlfutwm config to home-manager/nixos using the home-manager herbstluftwm module.
currently the function for generating the final autostart bash script dose not allow for bash functions in the extraconfig string.
my question is, why did you implement it in this way?
this part at the beginning:
and this part at the end:
don't allow bash scripting, removing them restores the expected behaviour of an normal hebstluftwm autoconfig file.
to me these parts seem redundant since the autoconfig file it self is already been executed.
i know that as mentioned in #2884, you can port the bash function into the let ... in section of the nix config, but since i use some of the functions in an second bash script for monitor handling, i dont want to maintain two versions of the same code.
my suggestion would be to add an option to disable this behaviour by omitting the above mentioned code blocks from the config generator.
best
tincotema
Maintainer CC
@olmokramer
System information
The text was updated successfully, but these errors were encountered: