Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

herbstluftwm: Make herbstclient alias optional #5566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

olmokramer
Copy link
Contributor

Description

The herbstclient alias made it impossible to use bash functions in the autostart script for herbstluftwm, as described in #5213.

This makes the herbstclient alias optional by adding an extra herbstclientAlias option on the herbstluftwm configuration. The new option defaults to false as to not confuse newcomers to the herbstluftwm module, which is not a breaking change because it was only an optimization.

Fixes #5213

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@olmokramer olmokramer force-pushed the herbstluftwm/optional-herbstclient-alias branch from 2d6f3af to c297d0c Compare June 22, 2024 09:08
@olmokramer
Copy link
Contributor Author

The test failures on macos don't seem to be related to this PR, these changes should only affect Linux.

The `herbstclient` alias in the generated `autostart` made it impossible
to use bash functions.

This makes the `herbstclient` alias optional by adding an extra
`herbstclientAlias` option on the herbstluftwm configuration. The new
option defaults to `false` as to not confuse newcomers to the
herbstluftwm module, which is not a breaking change because it was only
an optimization.
@olmokramer olmokramer force-pushed the herbstluftwm/optional-herbstclient-alias branch from 2b82508 to 1874860 Compare October 5, 2024 17:49
Copy link

stale bot commented Jan 4, 2025

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Jan 4, 2025
@olmokramer
Copy link
Contributor Author

Still relevant.

@stale stale bot removed the status: stale label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

herbstluftwm extraconfig dose not support bash functions
1 participant