sway: fix workspace 10 missing from default config

[emilylange]

Description

workspace 10 is part of upstream's default config, but was missing in home-manager.

The initial "sway: add module" PR (#829, 02d6040) went through multiple iterations and had workspace 10 included for a brief moment. Until the author removed it in a force-push commenting

Have removed the last change which added bound ${modifer}+0 to workspace number 10 as this messed up workspace numbering in sway.

#829 (comment)

The reason might have been, that sway used to sort the workspaces in the order they appeared in the config.

Attribute sets in nix are sorted, but not "naturally sorted", meaning bindsym Mod1+0 workspace number 10 comes before bindsym Mod1+0 workspace number 1.

It's unclear if that's what really happened. A workaround would have been to use lib.lists.naturalSort in keybindingsStr.

But I cannot reproduce this anymore in any way.
I assume this has been fixed many years ago by now.

upstream config: https://github.com/swaywm/sway/blob/020a572ed615b8fe272c7566a27ee0abe73a58d7/config.in#L113-L134

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

Maintainer CC

@Scrumplex @alexarice @sumnerevans @SebTM @oxalica

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[SebTM]

LGTM, another reason it might got left out is that the first defined workspace in keybindings is the workspace active when sway starts, but this can be controlled with defaultWorkspace already.

[emilylange]

not stale (trying to get rid of the stale label and not sure if the review does not count for whatever reason -- might delete later, in case you wondered why you can see this comment in your mail inbox but not on github)

[Toomoch]

Somehow my Sway desktop is booting to workspace 10 always since I updated my inputs, and I can't seem to know why until I found this commit. Could it be the cause?
Here is my config: https://github.com/Toomoch/nixos-config/blob/testing/home/arnau/sway/default.nix

[SebTM]

Yes, but I don't see you using https://nix-community.github.io/home-manager/options.xhtml#opt-wayland.windowManager.sway.config.defaultWorkspace

correct? Then it's handled like explained here: #4636 (review)

[Toomoch]

Yes, but I don't see you using https://nix-community.github.io/home-manager/options.xhtml#opt-wayland.windowManager.sway.config.defaultWorkspace

correct? Then it's handled like explained here: #4636 (review)

So sorry, I didn't even read the whole issue.
That makes sense as number 10 is defined before number 1, see the config file home-manager built:

Using defaultWorkspace fixed it, thank you very much.

[Toomoch]

Maybe it would be a good idea to set it to 1 if using mkOptionDefault in the keybindings.

[philipwilk]

Hi, I've run into this as well - my default workspace being changed to 10. This is manageable on single display environments, where you can change the default workspace to be 1 explicitly, but this does not work with multi monitor setups. When i connect my laptop to a monitor, the laptop screen is workspace 1 but the monitor is workspace 10 instead of workspace 2. How could I workaround this?
If there is an option to set the default workspace for a specific monitor or resolution or something, I cannot use it, because I'm not using just one specific monitor; I'm using different ones across the uni, and I can't practically manually create a config for each one.

[emilylange]

Guess we could use lib.lists.naturalSort in keybindingsStr (from my opening comment).
Any objections?

[philipwilk]

I'm not sure how to manually test it on my local machine without switching my hm input but i'd be up to try it

[emilylange]

hmm turns out throwing lib.lists.naturalSort at keybindingsStr is not as straight forward as I thought :(

[alexarice]

is it possible to add mkAfter to the workspace 10 bindings?

[Scrumplex]

Why don't we just set a default value for defaultWorkspace?

[emilylange]

Why don't we just set a default value for defaultWorkspace?

Because it would not fix the ordering issue on multi-monitor setups. See #4636 (comment)