Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixgl: use original package name #6632

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Smona
Copy link
Contributor

@Smona Smona commented Mar 14, 2025

Description

Some home manager modules depend on the name, so changing it in the wrapper can break them.

Fixes #6608

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

Some home manager modules depend on the name, so changing it in the
wrapper can break them.
@teto
Copy link
Collaborator

teto commented Mar 14, 2025

it's helpful to show in store path that it is a nixgl wrapper. I find it odd for a package to change its config based on its name. Maybe something to change more in the upstream package

@Smona
Copy link
Contributor Author

Smona commented Mar 14, 2025

That's a good point, I think this specific issue could possibly be fixed by using pname rather than name in the part of the chromium module highlighted here. I only went with this approach first because it would prevent instances of this problem in other modules from generating issues for the nixgl module going forward. I agree though that this change makes the store path less clear, so it's less than ideal.

@Smona
Copy link
Contributor Author

Smona commented Mar 14, 2025

I see @tadfisher authored that line, any thoughts on the alternative mentioned above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: config.lib.nixGL.wrap leads to missing Chromium extensions
2 participants