Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from global to per-process core dumps on SmartOS #894

Merged

Conversation

misterdjules
Copy link
Contributor

This allows for controlling core files limits per process (e.g per
tests).

Ref: nodejs/node#14013

This allows for controlling core files limits per process (e.g per
tests).

Ref: nodejs/node#14013
refack

This comment was marked as off-topic.

gibfahn

This comment was marked as off-topic.

@gibfahn
Copy link
Member

gibfahn commented Sep 22, 2017

@nodejs/platform-smartos , anyone else want to review?

@misterdjules
Copy link
Contributor Author

@gibfahn May I merge these changes? I don't know what the process is for merging changes in this repository, so a bit of guidance would be appreciated in order for me to ensure that I follow any process currently established.

@gibfahn
Copy link
Member

gibfahn commented Sep 29, 2017

@gibfahn May I merge these changes? I don't know what the process is for merging changes in this repository, so a bit of guidance would be appreciated in order for me to ensure that I follow any process currently established.

If it's been reviewed and has been open for a couple of days, anyone in nodejs/build can merge. We tend to follow a more relaxed version of the core rules (so Squash and merge is fine).

@gibfahn gibfahn merged commit 29bc6bc into nodejs:master Sep 29, 2017
@misterdjules
Copy link
Contributor Author

Thanks for merging and for the info, I'll keep that in mind next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants