Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: skip split2 #821

Merged
merged 2 commits into from
Aug 21, 2020
Merged

lookup: skip split2 #821

merged 2 commits into from
Aug 21, 2020

Conversation

MylesBorins
Copy link
Contributor

The current published version has a gitHead in the packument
that is not available on github

Refs: mcollina/split2#40

The current published version has a gitHead in the packument
that is not available on github

Refs: mcollina/split2#40
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #821 into main will decrease coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   96.18%   95.34%   -0.85%     
==========================================
  Files          30       26       -4     
  Lines         892      880      -12     
==========================================
- Hits          858      839      -19     
- Misses         34       41       +7     
Impacted Files Coverage Δ
lib/spawn.js 69.23% <0.00%> (-30.77%) ⬇️
lib/match-conditions.js 91.48% <0.00%> (-2.13%) ⬇️
bin/citgm.js 98.00% <0.00%> (-2.00%) ⬇️
bin/citgm-all.js 91.00% <0.00%> (-1.00%) ⬇️
test/fixtures/omg-i-pass-with-scripts/build.js
test/fixtures/omg-i-write-to-tmpdir/test.js
test/fixtures/omg-i-pass-with-scripts/test.js
...ixtures/omg-i-pass-with-install-param/test_args.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700b5a4...c2b8c99. Read the comment docs.

Co-authored-by: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins merged commit 4b51d86 into main Aug 21, 2020
@MylesBorins MylesBorins deleted the skip-split2 branch August 21, 2020 21:01
@mcollina
Copy link
Member

Should be fixed, can we add it back? Thanks

@mcollina
Copy link
Member

v3.2.2 has the matching tag on both github and npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants