dep: remove mkdirp dependency #2084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dep: mkdirp hasn't been updated in 4 years, and node's fs library has had a recursive option for `fs` since v10.12 (oldest active LTS version). Additionally `mkdirp` depends on a version of library `minimist` that has a minor vulnerability associated. Refs: * https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback * https://npmjs.com/advisories/1179
rharriso
force-pushed
the
remove-very-old-mkdirp
branch
from
c782ba9 to
4ebbc9e
Compare
rvagg
requested changes
Mar 30, 2020
There was a problem hiding this comment.
Yeah, this is fine. We'd proposed to do this for 6.x (or more likely 7.x) but we're going to have to stick with mkdirp for the remainder of 5.x's life and this is still the version that npm is choosing to pull in.
Just remove nodeFs and use fs directly and this should be good to go.
| @@ -1,10 +1,10 @@ | |||
| 'use strict' | |||
|
|
|||
| const nodeFs = require('fs') | |||
There was a problem hiding this comment.
remove this and just use fs, it should pass through properly
rvagg
added a commit
that referenced
this pull request
May 13, 2020
only supported on Node.js 10+ Closes: #2084
rvagg
added a commit
that referenced
this pull request
May 13, 2020
only supported on Node.js 10+ Closes: #2084
rvagg
added a commit
that referenced
this pull request
Jun 2, 2020
only supported on Node.js 10+ Closes: #2084
rvagg
added a commit
that referenced
this pull request
Jun 3, 2020
only supported on Node.js 10+ Closes: #2084 PR-URL: #2123 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1071 ### Checklist
npm install && npm testpassesDescription of change
mkdirphasn't been updated in 4 years, and node's fs libraryhas had a recursive option for
fssince v10.12 (oldest active LTSversion)
I was notified of an issue with
minmist(a dependency ofmkdirp) bynpm audit. https://npmjs.com/advisories/1179. This library shouldn't be necessary as the old LTS supports recursive directory creation