-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try libnode.dll first in load_exe_hook #2834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Can anyone review? |
I'm not quite sure if it still make sense after such a long time. Maybe you can consider cherry-picking dd56ec0 |
lukekarrys
approved these changes
Dec 2, 2024
I have rebased this PR to include only dd56ec0 |
Thank you |
Thank you, will it merge? |
i hope so |
StefanStojanovic
approved these changes
Dec 10, 2024
Kreijstal
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm test
passesDescription of change
It is a following PR of nodejs/node#47682.
I've tried to rename my executable to
node.exe
but the error is still there.That's because the node.js's symbol is in
libnode.dll
but not in my executable. So,GetModuleHandle(NULL)
will not work.However, I think we can try to load
libnode.dll
first. If failed then fallback to try the executable. That will solve the problem and keep the original path work either.Maybe it is looks like a edge case, but as Node.js has a embedding tutorial in the doc, I think it's worth to do this.
Or please tell me if there is a more simple way to solve my problem.
Test is not included because I need to provide a huge nodedll binary.
Thank you, I love node.js.