Buffer doesn't throw error for invalid parameter type

[ghostoy]

In Node.js 0.10, invalid parameter type String will cause some Buffer APIs, like writeUint32LE('some string', 0), throwing an "value is out of bounds" error. The parameter is checked by checkInt function:

function checkInt(buffer, value, offset, ext, max, min) {
  if ((value % 1) !== 0 || value > max || value < min)
    throw TypeError('value is out of bounds');
  if ((offset % 1) !== 0 || offset < 0)
    throw TypeError('offset is not uint');
  if (offset + ext > buffer.length || buffer.length + offset < 0)
    throw RangeError('Trying to write outside buffer length');
}

However in Node.js / io.js 0.11 & 0.12, the check function is changed into following, which doesn't throw any errors for invalid values:

function checkInt(buffer, value, offset, ext, max, min) {
  if (!(buffer instanceof Buffer))
    throw new TypeError('buffer must be a Buffer instance');
  if (value > max || value < min)
    throw new TypeError('value is out of bounds');
  if (offset + ext > buffer.length)
    throw new RangeError('index out of range');
}

This is an inconsistent behavior, which should be fixed.

[bnoordhuis]

I believe the motivation was to make it more aligned with the implicit type coercion that you get in most places; e.g. typed arrays: new Int32Array(['0x1badbabe'])

@trevnorris I believe you were responsible for that change? Can you comment?

[trevnorris]

Exactly what @bnoordhuis said.

[ghostoy]

In other word, this is a fix rather than a bug, right?

[chrisdickinson]

Closing this as "working as intended." If I'm incorrect, please let me know and I can reopen.