New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs flag `rs` is not documented, but it was implemented #48452

Closed

rentalhost opened this issue Jun 13, 2023 · 0 comments · Fixed by #48463

Labels

fs

rentalhost commented Jun 13, 2023

node/lib/internal/fs/utils.js

Lines 593 to 598 in 8bc6e19

    
           case 'r' : return O_RDONLY; 
        
           case 'rs' : // Fall through. 
        
           case 'sr' : return O_RDONLY | O_SYNC; 
        
           case 'r+' : return O_RDWR; 
        
           case 'rs+' : // Fall through. 
        
           case 'sr+' : return O_RDWR | O_SYNC;

https://stackoverflow.com/a/50489996/755393

VoltrexKeyva added the fs label

sinkhaha mentioned this issue

doc: update fs flags documentation #48463

Merged

nodejs-github-bot closed this as completed in #48463

nodejs-github-bot pushed a commit that referenced this issue


          doc: update fs flags documentation

0d725d6

PR-URL: #48463
Fixes: #48452
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

RafaelGSS pushed a commit that referenced this issue


          doc: update fs flags documentation

e2d579e

PR-URL: #48463
Fixes: #48452
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this issue


          doc: update fs flags documentation

2d86851

PR-URL: nodejs#48463
Fixes: nodejs#48452
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this issue


          doc: update fs flags documentation

7d7324d

PR-URL: nodejs#48463
Fixes: nodejs#48452
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

ruyadorno pushed a commit that referenced this issue


          doc: update fs flags documentation

9e94b65

PR-URL: #48463
Fixes: #48452
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

ruyadorno pushed a commit that referenced this issue


          doc: update fs flags documentation

0056cb9

PR-URL: #48463
Fixes: #48452
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment