Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix compiler warning in NodeCryptoEnv #49206

Merged
merged 1 commit into from
Aug 24, 2023
Merged

test: fix compiler warning in NodeCryptoEnv #49206

merged 1 commit into from
Aug 24, 2023

Conversation

tniessen
Copy link
Member

This fixes warning: value computed is not used when calling BIO_seek():

../test/cctest/test_node_crypto_env.cc: In member function ‘virtual void NodeCryptoEnv_LoadBIO_Test::TestBody()’:
../deps/openssl/openssl/include/openssl/../../../config/././archs/linux-x86_64/asm/include/openssl/bio.h:495:26: warning: value computed is not used [-Wunused-value]
  495 | # define BIO_seek(b,ofs) (int)BIO_ctrl(b,BIO_C_FILE_SEEK,ofs,NULL)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../test/cctest/test_node_crypto_env.cc:26:3: note: in expansion of macro ‘BIO_seek’
   26 |   BIO_seek(bio.get(), 2);
      |   ^~~~~~~~

Refs: #47160

@tniessen
test: fix compiler warning in NodeCryptoEnv
5d79fb2 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: nodejs#47160
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 16, 2023
@tniessen tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. review wanted PRs that need reviews. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53528/

mhdawson
mhdawson approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen tniessen removed the review wanted PRs that need reviews. label Aug 23, 2023
@github-actions github-actions bot mentioned this pull request Aug 24, 2023
Open
27 tasks
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6117cc3 into nodejs:main Aug 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 6117cc3

This was referenced Aug 25, 2023
Open
Open
Open
Open
Open
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@tniessen @UlisesGascon
test: fix compiler warning in NodeCryptoEnv
a11e64e 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: #47160
PR-URL: #49206
Reviewed-By: Michael Dawson <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@tniessen @alexfernandez
test: fix compiler warning in NodeCryptoEnv
e835e37 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: nodejs#47160
PR-URL: nodejs#49206
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@tniessen @targos
test: fix compiler warning in NodeCryptoEnv
ddebd29 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: #47160
PR-URL: #49206
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: fix compiler warning in NodeCryptoEnv
4308c16 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: nodejs/node#47160
PR-URL: nodejs/node#49206
Reviewed-By: Michael Dawson <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: fix compiler warning in NodeCryptoEnv
b78535c 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: nodejs/node#47160
PR-URL: nodejs/node#49206
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tniessen @nodejs-github-bot @mhdawson