Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix build with Python 3.12 #50582

Merged
merged 1 commit into from
Nov 8, 2023
Merged

build: fix build with Python 3.12 #50582

merged 1 commit into from
Nov 8, 2023

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 6, 2023

Replace distutils.version.StrictVersion with
packaging.version.Version.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 6, 2023
@lpinca lpinca force-pushed the fix/build-with-python-3-12 branch from 66e9326 to 676e9b4 Compare November 6, 2023 20:09
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55466/

@lpinca
build: fix build with Python 3.12
7ce12ad 
Replace `distutils.version.StrictVersion` with
`packaging.version.Version`.

Refs: nodejs#50209 (comment)
@lpinca lpinca force-pushed the fix/build-with-python-3-12 branch from 676e9b4 to 7ce12ad Compare November 7, 2023 07:33
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55468/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55479/

@richardlau richardlau added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 7, 2023
@richardlau
Copy link
Member

Like #50209 this depends on #50380.
cc @nodejs/backporters

@legendecas
Copy link
Member

Can we fast-track this? configure on the main branch with python3.12 installed on the system will fail.

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Fast-track has been requested by @lpinca. Please 👍 to approve.

@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Open
16 tasks
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 95534ad into nodejs:main Nov 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 95534ad

@lpinca lpinca deleted the fix/build-with-python-3-12 branch November 8, 2023 21:00
This was referenced Nov 9, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 11, 2023
@lpinca @targos
build: fix build with Python 3.12
164fced 
Replace `distutils.version.StrictVersion` with
`packaging.version.Version`.

Refs: #50209 (comment)
PR-URL: #50582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@lpinca @targos
build: fix build with Python 3.12
22eb025 
Replace `distutils.version.StrictVersion` with
`packaging.version.Version`.

Refs: #50209 (comment)
PR-URL: #50582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@lpinca @UlisesGascon
build: fix build with Python 3.12
0a5e9c1 
Replace `distutils.version.StrictVersion` with
`packaging.version.Version`.

Refs: #50209 (comment)
PR-URL: #50582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
@richardlau richardlau added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Mar 26, 2024
joshuafried pushed a commit to joshuafried/node that referenced this pull request Sep 13, 2024
@lpinca @joshuafried
build: fix build with Python 3.12
c6119e0 
Replace `distutils.version.StrictVersion` with
`packaging.version.Version`.

Refs: nodejs/node#50209 (comment)
PR-URL: nodejs/node#50582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
@lpinca @aduh95
build: fix build with Python 3.12
6ba4ebd 
Replace `distutils.version.StrictVersion` with
`packaging.version.Version`.

Refs: #50209 (comment)
PR-URL: #50582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@aduh95 aduh95 added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed lts-watch-v18.x PRs that may need to be released in v18.x. labels Nov 2, 2024
@aduh95 aduh95 mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. backported-to-v20.x PRs backported to the v20.x-staging branch. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpinca @nodejs-github-bot @richardlau @legendecas @aduh95