Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update metalsmith-permalinks #1854

Merged
merged 1 commit into from
Oct 25, 2018
Merged

update metalsmith-permalinks #1854

merged 1 commit into from
Oct 25, 2018

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 25, 2018

This resolves the only issue reported currently by npm audit.

Major version change for the dependency, but it doesn't appear to change the results for our permalinks.

@Trott
update metalsmith-permalinks
fe1593b 
This resolves the only issue reported currently by `npm audit`.
fhemberger
fhemberger approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@fhemberger fhemberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we don't set any special slug options for the permalinks, we're not affected by the semver major bump.

@fhemberger fhemberger merged commit fa18587 into nodejs:master Oct 25, 2018
@snyk-bot snyk-bot mentioned this pull request Jan 1, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhemberger fhemberger fhemberger approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @fhemberger @ZYSzys