Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: upgraded react 19 next 15.2 #7531

Merged
merged 6 commits into from
Mar 1, 2025
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Mar 1, 2025

This PR upgrades all packages and ensures a smooth Next.js 15.2 and React 19 migration.

The gist of this upgrade is that some nested-dependencies/peerDependencies are still with types/react 18 and types/react-dm 18 which causes TypeScript to compute that the globally exposed React types (since some dependencies are doing declare globals which is discouraged) versus the imported ones are different.

Pretty much very little had to be updated, besides of just forcing our types.

@ovflowd ovflowd requested a review from a team as a code owner March 1, 2025 18:20
Copy link

vercel bot commented Mar 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 1, 2025 6:46pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 1, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 90 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@AugustinMauroy AugustinMauroy mentioned this pull request Mar 1, 2025
4 tasks
@ovflowd
Copy link
Member Author

ovflowd commented Mar 1, 2025

@nodejs/nodejs-website @nodejs/web-infra I'm expediting this, as this potentially blocks other migrations such as Cloudflare and what not.

cc @dario-piotrowicz be aware of this change, rebase will be needed, and this is a good opportunity for us to investigate Next.js 15.2 is still compatible with our changes.

@ovflowd ovflowd enabled auto-merge March 1, 2025 18:31
Copy link

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Mar 1, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
88.75% (742/836) 76.1% (242/318) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.328s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 1, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 1, 2025
@ovflowd ovflowd disabled auto-merge March 1, 2025 18:48
@ovflowd ovflowd enabled auto-merge March 1, 2025 18:48
@ovflowd ovflowd disabled auto-merge March 1, 2025 18:49
@ovflowd ovflowd merged commit 2c6dd62 into main Mar 1, 2025
15 of 16 checks passed
@ovflowd ovflowd deleted the chore/upgrade-react-19-next-152 branch March 1, 2025 18:50
@bjohansebas
Copy link

This was quick, wow

@ovflowd
Copy link
Member Author

ovflowd commented Mar 1, 2025

This was quick, wow

Yup, it is pretty much dependency updates and tiny fixes for said dep updates. This falls under the policy of things that can be expedited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants