fix(correct-ts-specifiers): use module.registerHooks (for bundling)
#38
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobJingleheimer
force-pushed
the
fix/correct-ts-specifiers/alias-module-registerhooks
branch
from
7889cf7 to
ae5bd7d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
AugustinMauroy
approved these changes
Feb 27, 2025
| module.register('@nodejs-loaders/alias', import.meta.url); | ||
| import * as aliasLoader from '@nodejs-loaders/alias/alias.loader.mjs'; | ||
|
|
||
| module.registerHooks(aliasLoader); |
There was a problem hiding this comment.
Suggested change
| module.registerHooks(aliasLoader); | |
| // Registering sync hooks to resolve ts path alias | |
| module.registerHooks(aliasLoader); |
This comment was marked as outdated.
This comment was marked as outdated.
Until available in `@types/node`
JakobJingleheimer
force-pushed
the
fix/correct-ts-specifiers/alias-module-registerhooks
branch
from
ce913c7 to
d89434c
Compare
|
CI is failing on node 22.x because |
|
Upstream fix to @types/node for type def: DefinitelyTyped/DefinitelyTyped#72122 |
|
When manually published, this now works with the codemod executable 🥳 Thanks Mo! |
|
Sweet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.