Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build on macos #66

Closed
HughHoyland opened this issue Mar 3, 2024 · 2 comments · Fixed by #67
Closed

Doesn't build on macos #66

HughHoyland opened this issue Mar 3, 2024 · 2 comments · Fixed by #67

Comments

@HughHoyland
Copy link
Contributor

HughHoyland commented Mar 3, 2024

The methods have different signatures on MacOS:

    #[cfg(not(target_os = "macos"))]
    fn set_clipboard(&mut self, text: String) {
        mq::window::clipboard_set(&text);
    }

    #[cfg(not(target_os = "macos"))]
    fn get_clipboard(&mut self) -> Option<String> {
        mq::window::clipboard_get()
    }

    #[cfg(target_os = "macos")]
    fn set_clipboard(&mut self, _mq_ctx: &mut mq::Context, text: String) {...}

    #[cfg(target_os = "macos")]
    fn get_clipboard(&mut self, _mq_ctx: &mut mq::Context) -> Option<String> {...}

but their calls only use the non-macos signature.

As the _mq_ctx argument is no longer used, can it be removed please?

@not-fl3
Copy link
Owner

not-fl3 commented Mar 3, 2024

sure, feel free to send a PR!

@HughHoyland
Copy link
Contributor Author

Oh, sure. Sorry, had a brain freeze. I couldn't fix the previous version I tried.
#67

not-fl3 pushed a commit that referenced this issue Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants