-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
danybony
commented
Jul 14, 2015
I'd say this addition is of questionable value. While it surely moves the no-op impls to Notils, making the code seem cleaner it might add some confusion for devs who know the interface, wondering where the rest of the events go. I think the benefit of having this in Notils is very marginal. |
but tbf everytime I use this interface I only want one of the 3 methods so 👍 from me |
@stefanhoth this is open to discussion. |
👍 from me as well. Death to no-ops! |
❌ needs an update of the readme @danybony The argument that there are other confusing APIs does not count :-) Happy with it as proguard removes the class if not needed. |
@friedger readme updated! |
👍 Letting @stefanhoth merge it |
I wouldn't X it but I still don't see the big benefit and would rather have this No-op base class in my own project. But if @malmstein or @blundell are big fans they should merge it. |
TextWatcher simple implementation
👼 |
💃 |