npm v7 fails on node v10.0 (~~and v10.1-v10.9~~)

[ljharb]

Current Behavior:

Run npm install on node v10.0 - v10.9, it will fail: https://github.com/ljharb/publishers/pull/8/checks?check_run_id=1834032724 / https://github.com/ljharb/es-value-fixtures/pull/2/checks?check_run_id=1833723968

Expected Behavior:

npm install to complete successfully, as it does on node v10.10+ (since engines.node is >= 10)

Steps To Reproduce:

I suspect this will happen on any npm install command on these node versions

Environment:

• Node: v10.0 - v10.9
• npm: v7.5.2

[wraithgar]

This is addressed by npm/installed-package-contents#4
npm/installed-package-contents#4

[ljharb]

Which version of npm will include this fix?

[wraithgar]

I believe this got pulled in with v7.5.3 #2626

[ljharb]

Hmm, v10.0 is still failing with TypeError: Cannot destructure property stat of 'undefined' or 'null'.: https://github.com/ljharb/publishers/pull/8/checks?check_run_id=1858247201 inside node_modules/@npmcli/node-gyp/lib/index.js:2:29, so i think this needs to be reopened - although npm/installed-package-contents@5f90dfa seems to have fixed v10.1-v10.9, yay!

[ljharb]

Specifically, this is because node v10.0 doesn't actually have fs.promises - however, util.promisify(fs.stat) should work there. I'll try to make a PR.

[ljharb]

Filed as npm/node-gyp#5.

[ruyadorno]

@ljharb it looks like there are a couple more places in the cli:

$ git grep require..fs...promises
lib/utils/reify-finish.js:const {writeFile} = require('fs').promises
node_modules/@npmcli/node-gyp/lib/index.js:const {stat} = require('fs').promises
node_modules/@npmcli/run-script/lib/is-server-package.js:const { stat } = require('fs').promises

[ljharb]

woof, ok

[ljharb]

npm/run-script#21 and #2654