feat: move atem-connection to be a peer-dependency #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids duplicating the dependency, while allowing library users to use a different version if they accept the compatability risk
Julusian
changed the title
mint-dewit
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
atem-connection is a dependnecy, and is then exported so that library users can use the correct identical version of atem-connection.
It is not very obvious that this is done and that this version should be used, so it likely isnt done by users.
Instead atem-connection is defined as a peerDependency. This makes it more explicit that the library is picky about the version it uses, but ultimately leaves that dependency up to the user.