fix: prevent in place reverse in setDatastore

nrkno · Nov 14, 2022 · 473ab71 · 473ab71
1 parent 8665273
commit 473ab71
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/timeline-state-resolver/src/conductor.ts b/packages/timeline-state-resolver/src/conductor.ts
@@ -1168,7 +1168,8 @@ export class Conductor extends EventEmitter<ConductorEvents> {
 
 				for (const deviceId of affectedDevices) {
 					const toBeFilled = _.compact([
-						this._deviceStates[deviceId].reverse().find((s) => s.time <= this.getCurrentTime()), // one state before now
+						// shallow clone so we don't reverse the array in place
+						[...this._deviceStates[deviceId]].reverse().find((s) => s.time <= this.getCurrentTime()), // one state before now
 						...this._deviceStates[deviceId].filter((s) => s.time > this.getCurrentTime()), // all states after now
 					])