Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added guard for asyncio registration for python 38 on windows #517

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

MSeal
Copy link
Member

@MSeal MSeal commented Jun 24, 2020

Fix for #515.

@MSeal MSeal requested review from minrk and captainsafia June 24, 2020 15:34
@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #517 into master will decrease coverage by 0.05%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   91.61%   91.56%   -0.06%     
==========================================
  Files          14       14              
  Lines        1252     1256       +4     
==========================================
+ Hits         1147     1150       +3     
- Misses        105      106       +1     

@MSeal
Copy link
Member Author

MSeal commented Jun 27, 2020

Codecov complained because it's 1 line more uncovered -- tests are all passing.

@MSeal MSeal merged commit 6507827 into nteract:master Jun 29, 2020
@MSeal MSeal deleted the winpy38fix branch August 18, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants