-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds GetRunLogs RPC, fixes loki-backend log sorting #3173
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
- Coverage 27.80% 27.75% -0.05%
==========================================
Files 378 378
Lines 43139 43199 +60
==========================================
- Hits 11994 11992 -2
- Misses 29697 29758 +61
- Partials 1448 1449 +1 ☔ View full report in Codecov by Sentry. |
Adds a unary rpc for retrieving logs to further simplify the frontend
Sorts the loki logs in memory for unary calls to properly sort them. They will still be broken for the stream endpoint.
Logs now refetch while run state is in running or pending and no longer checks logs for whether or not to rerun.