Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds GetRunLogs RPC, fixes loki-backend log sorting #3173

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Jan 22, 2025

Adds a unary rpc for retrieving logs to further simplify the frontend
Sorts the loki logs in memory for unary calls to properly sort them. They will still be broken for the stream endpoint.
Logs now refetch while run state is in running or pending and no longer checks logs for whether or not to rerun.

@nickzelei nickzelei added the Tech Debt Created by Linear-GitHub Sync label Jan 22, 2025
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 5:38pm

Copy link

github-actions bot commented Jan 22, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 22, 2025, 5:38 PM

@nickzelei nickzelei merged commit 571b7ee into main Jan 22, 2025
19 checks passed
@nickzelei nickzelei deleted the nick/adds-unary-log-endpoint branch January 22, 2025 17:47
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes missing coverage. Please review.

Project coverage is 27.75%. Comparing base (0807f85) to head (f09fd84).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
backend/services/mgmt/v1alpha1/job-service/runs.go 0.00% 78 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3173      +/-   ##
==========================================
- Coverage   27.80%   27.75%   -0.05%     
==========================================
  Files         378      378              
  Lines       43139    43199      +60     
==========================================
- Hits        11994    11992       -2     
- Misses      29697    29758      +61     
- Partials     1448     1449       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech Debt Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants