Adds destination schema validation to job destinations #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alishakawaguchi
commented
Feb 10, 2025
•
alishakawaguchi
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3242 +/- ##
==========================================
+ Coverage 23.48% 23.61% +0.13%
==========================================
Files 378 379 +1
Lines 43489 43656 +167
==========================================
+ Hits 10215 10311 +96
- Misses 32229 32300 +71
Partials 1045 1045 ☔ View full report in Codecov by Sentry. |
Benchstat Geomean Results0.18% sec/op, -0.09% B/op, 0.00% allocs/op Benchstat results |
alishakawaguchi
requested review from
nickzelei
and removed request for
nickzelei
nickzelei
reviewed
Feb 10, 2025
| <Skeleton className="w-full h-24 rounded-lg" /> | ||
| )} | ||
| {!isValidatingSchema && columnErrors && ( | ||
| <div> |
There was a problem hiding this comment.
can this be refactored into a component?
| !isValidateMappingsLoading && | ||
| tableErrors.length > 0 && ( | ||
| !isValidatingSchema && | ||
| tableErrors && ( | ||
| <div> |
There was a problem hiding this comment.
can this be refactored into a component?
| @@ -1665,3 +1723,28 @@ func getJobSourceConnectionId(jobSource *mgmtv1alpha1.JobSource) (*string, error | |||
| } | |||
| return connectionIdToVerify, nil | |||
| } | |||
|
|
|||
| func getConnectionSchemaConfigByConnectionType(connection *mgmtv1alpha1.Connection) (*mgmtv1alpha1.ConnectionSchemaConfig, error) { | |||
There was a problem hiding this comment.
what is the purpose of this function? and why are all of the configs effectively just empty?
There was a problem hiding this comment.
only the SQL configs are empty. the document storage configs need jobId or jobRunId.
it's needed for the connection data builder GetSchema function.
GetSchema(ctx context.Context, config *mgmtv1alpha1.ConnectionSchemaConfig) ([]*mgmtv1alpha1.DatabaseColumn, error)
| MysqlConfig: &mgmtv1alpha1.MysqlSchemaConfig{}, | ||
| }, | ||
| }, nil | ||
| case *mgmtv1alpha1.ConnectionConfig_DynamodbConfig: |
There was a problem hiding this comment.
is this supported to be mssql?
nickzelei
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.