Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection data service not supporting SQLServer #3262

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

alishakawaguchi
Copy link
Contributor

@alishakawaguchi alishakawaguchi commented Feb 14, 2025

also fixes job mapping validation error on first page load saying that connection id is missing
fast follow: connection data service api tests for mssql

@alishakawaguchi alishakawaguchi added the bug Something isn't working label Feb 14, 2025
@alishakawaguchi alishakawaguchi self-assigned this Feb 14, 2025
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Feb 14, 2025 6:30pm

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.38%. Comparing base (1649580) to head (682cb54).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/connectiondata/connectiondata.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3262      +/-   ##
==========================================
- Coverage   23.38%   23.38%   -0.01%     
==========================================
  Files         387      387              
  Lines       44448    44448              
==========================================
- Hits        10396    10393       -3     
- Misses      32996    32997       +1     
- Partials     1056     1058       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alishakawaguchi alishakawaguchi merged commit dd8480b into main Feb 14, 2025
18 of 20 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/mssql-bug branch February 14, 2025 18:40
Copy link

Benchstat Geomean Results

1.19% sec/op, -0.01% B/op, 0.00% allocs/op

Benchstat results
                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │       sec/op       │    sec/op     vs base              │
CleanPostgresType-4                         42.63n ± 4%   42.92n ±  4%       ~ (p=0.461 n=6)
Runner_Single-4                             7.713µ ± 5%   7.888µ ± 18%       ~ (p=0.180 n=6)
GenerateBool-4                              11.45n ± 1%   11.45n ±  3%       ~ (p=0.961 n=6)
GenerateBusinessName-4                      285.4n ± 0%   312.9n ±  3%  +9.65% (p=0.002 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.55n ±  0%       ~ (p=0.132 n=6)
GenerateCategorical-4                       104.1n ± 2%   104.5n ±  2%       ~ (p=0.143 n=6)
GenerateCity-4                              173.7n ± 0%   176.9n ±  1%  +1.81% (p=0.002 n=6)
GenerateCountry-4                           105.2n ± 1%   105.2n ±  1%       ~ (p=0.784 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.348µ ±  0%       ~ (p=0.286 n=6)
GenerateFirstName-4                         203.9n ± 0%   205.5n ±  0%  +0.76% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%   28.91n ±  3%  +0.61% (p=0.019 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.437µ ±  0%       ~ (p=0.394 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.318µ ±  2%  +7.90% (p=0.002 n=6)
GenerateGender-4                            41.42n ± 0%   41.70n ±  0%  +0.68% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%   28.23n ±  1%       ~ (p=0.667 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   51.67n ±  0%       ~ (p=0.288 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   176.5n ±  0%       ~ (p=0.058 n=6)
GenerateIpAddress-4                         569.3n ± 0%   569.2n ±  1%       ~ (p=1.000 n=6)
GenerateLastName-4                          187.4n ± 1%   192.2n ±  1%  +2.56% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   982.7n ±  0%       ~ (p=0.589 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.011µ ±  0%  -0.54% (p=0.006 n=6)
GenerateSSN-4                               305.8n ± 1%   307.4n ±  2%  +0.54% (p=0.037 n=6)
GenerateState-4                             105.2n ± 2%   105.9n ±  0%       ~ (p=0.169 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   204.2n ±  2%       ~ (p=0.561 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   179.5n ±  1%       ~ (p=0.325 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   77.48n ±  0%       ~ (p=0.102 n=6)
GenerateUsername-4                          351.5n ± 0%   364.1n ±  2%  +3.59% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   104.9n ±  1%       ~ (p=0.069 n=6)
GenerateUUID-4                              734.0n ± 0%   734.2n ±  0%       ~ (p=0.937 n=6)
GenerateZipcode-4                           105.2n ± 2%   105.8n ±  0%       ~ (p=0.104 n=6)
TransformCharacterScramble-4                171.8n ± 1%   172.4n ±  1%       ~ (p=0.065 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   181.0n ±  0%       ~ (p=0.372 n=6)
TransformEmail-4                            1.798µ ± 2%   1.803µ ±  1%       ~ (p=0.333 n=6)
TransformFirstName-4                        233.9n ± 0%   236.3n ±  5%  +1.05% (p=0.002 n=6)
TransformFloat64-4                          110.8n ± 4%   111.5n ±  1%       ~ (p=0.900 n=6)
TransformFullName-4                         1.235µ ± 2%   1.300µ ±  2%  +5.31% (p=0.002 n=6)
TransformInt64-4                            33.74n ± 1%   33.82n ±  1%       ~ (p=0.699 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   58.73n ± 34%  +1.55% (p=0.026 n=6)
TransformLastName-4                         191.6n ± 0%   199.6n ±  4%  +4.15% (p=0.002 n=6)
TransformString-4                           1.022µ ± 0%   1.026µ ±  1%       ~ (p=0.076 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   213.5n ±  0%       ~ (p=0.058 n=6)
TransformUuid-4                             36.54n ± 1%   36.90n ±  0%  +1.00% (p=0.002 n=6)
geomean                                     194.0n        196.3n        +1.19%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.306Ki ± 2%       ~ (p=0.240 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 3%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.01%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants