Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Runs Page to work with Child Workflows #3264

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Feb 14, 2025 10:49pm

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Please upload report for BASE (resumable-sync@eb0ae81). Learn more about missing BASE report.

Files with missing lines Patch % Lines
backend/services/mgmt/v1alpha1/job-service/runs.go 0.00% 65 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             resumable-sync    #3264   +/-   ##
=================================================
  Coverage                  ?   22.49%           
=================================================
  Files                     ?      390           
  Lines                     ?    44852           
  Branches                  ?        0           
=================================================
  Hits                      ?    10090           
  Misses                    ?    33739           
  Partials                  ?     1023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchstat Geomean Results

0.20% sec/op, -0.01% B/op, 0.00% allocs/op

Benchstat results
                                   │ main-benchmark.txt │       branch-benchmark.txt        │
                                   │       sec/op       │   sec/op     vs base              │
CleanPostgresType-4                         42.63n ± 4%   42.02n ± 2%  -1.43% (p=0.004 n=6)
Runner_Single-4                             7.713µ ± 5%   7.786µ ± 3%       ~ (p=0.937 n=6)
GenerateBool-4                              11.45n ± 1%   11.46n ± 2%       ~ (p=0.736 n=6)
GenerateBusinessName-4                      285.4n ± 0%   301.6n ± 6%       ~ (p=0.065 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.35n ± 1%       ~ (p=0.390 n=6)
GenerateCategorical-4                       104.1n ± 2%   101.2n ± 1%  -2.74% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%   174.2n ± 1%       ~ (p=0.558 n=6)
GenerateCountry-4                           105.2n ± 1%   105.2n ± 1%       ~ (p=0.729 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.341µ ± 1%       ~ (p=0.069 n=6)
GenerateFirstName-4                         203.9n ± 0%   199.7n ± 1%  -2.06% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%   28.27n ± 2%  -1.60% (p=0.026 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.460µ ± 1%       ~ (p=0.065 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.221µ ± 1%       ~ (p=0.511 n=6)
GenerateGender-4                            41.42n ± 0%   41.18n ± 2%       ~ (p=0.193 n=6)
GenerateInt64-4                             28.41n ± 2%   28.21n ± 1%       ~ (p=0.589 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   55.24n ± 1%  +7.36% (p=0.002 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   175.0n ± 3%       ~ (p=0.426 n=6)
GenerateIpAddress-4                         569.3n ± 0%   532.4n ± 0%  -6.47% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%   193.2n ± 2%  +3.04% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   979.0n ± 0%  -0.66% (p=0.015 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.004µ ± 1%  -1.23% (p=0.004 n=6)
GenerateSSN-4                               305.8n ± 1%   302.7n ± 0%  -1.00% (p=0.002 n=6)
GenerateState-4                             105.2n ± 2%   106.4n ± 1%  +1.14% (p=0.037 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   206.2n ± 1%  +1.10% (p=0.004 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   172.2n ± 1%  -3.99% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   74.03n ± 1%  -4.02% (p=0.002 n=6)
GenerateUsername-4                          351.5n ± 0%   350.1n ± 2%       ~ (p=0.900 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   103.2n ± 1%  -0.96% (p=0.013 n=6)
GenerateUUID-4                              734.0n ± 0%   743.2n ± 0%  +1.26% (p=0.002 n=6)
GenerateZipcode-4                           105.2n ± 2%   104.9n ± 1%       ~ (p=0.584 n=6)
TransformCharacterScramble-4                171.8n ± 1%   175.1n ± 1%  +1.92% (p=0.002 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   176.7n ± 0%  -1.91% (p=0.002 n=6)
TransformEmail-4                            1.798µ ± 2%   1.812µ ± 2%       ~ (p=0.143 n=6)
TransformFirstName-4                        233.9n ± 0%   235.9n ± 1%  +0.86% (p=0.002 n=6)
TransformFloat64-4                          110.8n ± 4%   111.2n ± 1%       ~ (p=0.937 n=6)
TransformFullName-4                         1.235µ ± 2%   1.307µ ± 4%  +5.83% (p=0.002 n=6)
TransformInt64-4                            33.74n ± 1%   33.64n ± 1%       ~ (p=0.699 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   62.16n ± 1%  +7.46% (p=0.002 n=6)
TransformLastName-4                         191.6n ± 0%   193.5n ± 3%  +0.97% (p=0.004 n=6)
TransformString-4                           1.022µ ± 0%   1.032µ ± 1%  +0.93% (p=0.004 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   208.2n ± 1%  -1.30% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%   36.69n ± 2%       ~ (p=0.223 n=6)
geomean                                     194.0n        194.4n       +0.20%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.307Ki ± 1%       ~ (p=0.195 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 0%       ~ (p=0.455 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.01%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@nickzelei nickzelei marked this pull request as ready for review February 14, 2025 23:07
@nickzelei nickzelei merged commit 10f00cd into resumable-sync Feb 14, 2025
17 of 18 checks passed
@nickzelei nickzelei deleted the nick/runs-events-page branch February 14, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant