Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Lexico Ordering with paged queries #3267

Merged
merged 6 commits into from
Feb 15, 2025
Merged

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Feb 15, 2025

  • Fixes lexicographical ordering for composite keys
  • More frontend fixes for activities and child workflows that do not complete successfully
  • Replaces truncate on insert with on conflict do nothing

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2025 10:57pm

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Project coverage is 22.72%. Comparing base (7e7d4f9) to head (90663be).
Report is 1 commits behind head on resumable-sync.

Files with missing lines Patch % Lines
worker/pkg/benthos/sql/input_sql_raw.go 0.00% 15 Missing ⚠️
worker/pkg/query-builder2/querybuilder.go 0.00% 13 Missing ⚠️
worker/pkg/workflows/datasync/workflow/workflow.go 0.00% 3 Missing ⚠️
worker/pkg/benthos/sql/output_sql_insert.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           resumable-sync    #3267      +/-   ##
==================================================
- Coverage           22.74%   22.72%   -0.02%     
==================================================
  Files                 390      390              
  Lines               44868    44877       +9     
==================================================
- Hits                10203    10198       -5     
- Misses              33641    33655      +14     
  Partials             1024     1024              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 15, 2025

Benchstat Geomean Results

0.19% sec/op, -0.05% B/op, 0.00% allocs/op

Benchstat results
                                   │ main-benchmark.txt │       branch-benchmark.txt        │
                                   │       sec/op       │   sec/op     vs base              │
CleanPostgresType-4                         42.63n ± 4%   42.16n ± 0%  -1.10% (p=0.002 n=6)
Runner_Single-4                             7.713µ ± 5%   7.839µ ± 2%       ~ (p=0.818 n=6)
GenerateBool-4                              11.45n ± 1%   11.43n ± 2%       ~ (p=0.855 n=6)
GenerateBusinessName-4                      285.4n ± 0%   296.2n ± 3%  +3.80% (p=0.002 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.48n ± 0%       ~ (p=0.394 n=6)
GenerateCategorical-4                       104.1n ± 2%   105.5n ± 1%  +1.34% (p=0.039 n=6)
GenerateCity-4                              173.7n ± 0%   173.3n ± 0%       ~ (p=0.087 n=6)
GenerateCountry-4                           105.2n ± 1%   104.8n ± 1%       ~ (p=0.245 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.341µ ± 0%  -0.41% (p=0.015 n=6)
GenerateFirstName-4                         203.9n ± 0%   199.2n ± 0%  -2.28% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%   28.82n ± 1%       ~ (p=0.074 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.460µ ± 2%  +2.13% (p=0.041 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.239µ ± 1%  +1.39% (p=0.002 n=6)
GenerateGender-4                            41.42n ± 0%   41.42n ± 0%       ~ (p=0.974 n=6)
GenerateInt64-4                             28.41n ± 2%   28.16n ± 0%       ~ (p=0.416 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   53.70n ± 0%  +4.35% (p=0.002 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   173.8n ± 1%  -1.14% (p=0.002 n=6)
GenerateIpAddress-4                         569.3n ± 0%   534.9n ± 1%  -6.03% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%   193.9n ± 2%  +3.44% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   983.4n ± 1%       ~ (p=0.589 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.018µ ± 0%       ~ (p=0.364 n=6)
GenerateSSN-4                               305.8n ± 1%   303.1n ± 0%  -0.88% (p=0.002 n=6)
GenerateState-4                             105.2n ± 2%   105.5n ± 1%       ~ (p=0.937 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   206.2n ± 1%  +1.13% (p=0.002 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   172.5n ± 0%  -3.79% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   77.30n ± 1%       ~ (p=0.240 n=6)
GenerateUsername-4                          351.5n ± 0%   357.4n ± 4%  +1.71% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   104.1n ± 0%       ~ (p=0.366 n=6)
GenerateUUID-4                              734.0n ± 0%   736.5n ± 0%       ~ (p=0.065 n=6)
GenerateZipcode-4                           105.2n ± 2%   105.1n ± 0%       ~ (p=0.517 n=6)
TransformCharacterScramble-4                171.8n ± 1%   175.0n ± 0%  +1.86% (p=0.002 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   176.5n ± 0%  -2.05% (p=0.002 n=6)
TransformEmail-4                            1.798µ ± 2%   1.816µ ± 0%       ~ (p=0.054 n=6)
TransformFirstName-4                        233.9n ± 0%   235.0n ± 1%       ~ (p=0.253 n=6)
TransformFloat64-4                          110.8n ± 4%   110.6n ± 0%       ~ (p=0.981 n=6)
TransformFullName-4                         1.235µ ± 2%   1.245µ ± 1%       ~ (p=0.093 n=6)
TransformInt64-4                            33.74n ± 1%   33.55n ± 0%       ~ (p=0.290 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   60.38n ± 1%  +4.39% (p=0.002 n=6)
TransformLastName-4                         191.6n ± 0%   191.5n ± 1%       ~ (p=0.602 n=6)
TransformString-4                           1.022µ ± 0%   1.025µ ± 2%       ~ (p=0.258 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   206.8n ± 0%  -1.99% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%   36.55n ± 0%       ~ (p=0.851 n=6)
geomean                                     194.0n        194.4n       +0.19%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.291Ki ± 3%  -0.95% (p=0.026 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       39.50 ± 1%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.05%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@nickzelei nickzelei marked this pull request as ready for review February 15, 2025 23:16
@nickzelei nickzelei merged commit ad7b6c2 into resumable-sync Feb 15, 2025
16 of 18 checks passed
@nickzelei nickzelei deleted the nick/resume-fixes1 branch February 15, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant